Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 8 months ago

Newsletter form

Oluwatobi•270
@LupoNetn
A solution to the Newsletter sign-up form with success message challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Serhii Orlenko•415
    @grifano
    Posted 8 months ago

    Hi! Congratulations on completing the challenge! 🎉 I hope this isn't your final solution, and that you'll continue working on improving it, especially the styles to match the design.

    Here are a few tips to help you improve your code:

    • HTML: Try to give your classes more meaningful names. Avoid using numbers like "hidden-2" as it makes it harder to understand what the class is doing.

    • CSS: I noticed the styles were missing, but remember that user experience is a key part of web development. Adding styles will really make your project stand out.

    • JavaScript: To make your JS cleaner, you can break it down into smaller functions. Also, using addEventListener for form handling is a good idea, like this:

      addEventListener('submit', function() {})
      

    Feel free to check out my code if you want.

    Overall, great work! You've shown a lot of progress and learned some valuable skills that will help you become an even better web developer. Keep it up!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub