Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

newsletter sign up page with error message

Shakil ahmed•260
@Shakil-a
A solution to the Newsletter sign-up form with success message challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

most proud:

  • worked a lot more on javascript logic for the error state handling
  • practised more with both my flex and grid skills
  • managed to get most of the requirements done and close to design

what i would do differently next time:

  • definitely spend more time on doing the javascript requirements before the css styling
  • take all screen sizes into consideration when styling
  • make a plan for the logic with pseudocode before starting to write the code
What challenges did you encounter, and how did you overcome them?

challenge 1 and solution: i went with mobile design first approach and at first failed to make it responsive for desktop version, how i solved this was through redoing the css and html structure and making a more responsive layout on mobile and expanding to larger screens

challenge 2 and solution: figuring out how to change the picture once we got to the desktop version without using a div and then just changing the background picture to the desktop one, how i solved this was through using the picture element and wrapping the default to the mobile img and then when the screen expands to 600px i have the source of the image of the desktop

What specific areas of your project would you like help with?

specific problems i would be grateful for help in :

  • i still have problems with creating responsive layouts with a mobile first approach and taking the larger screens in consideration, some advice on how i can make it look good for the mobile, tablet and laptop screen sizes

  • any bad practises i implemented and some suggestion how to change that

  • if my javascript logic is okay or was there a better way to achieve this

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Prem Kumar•370
    @prem-kumart
    Posted about 1 year ago
    • The solution looks good.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub