Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 2 months ago

Newsletter sign up with success message using Flexbox

P
M Rafay•140
@the-Exalter
A solution to the Newsletter sign-up form with success message challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • 6alactico•470
    @6alactico
    Posted about 2 months ago

    Great job on the interactivity! I have a few suggestions to improve structure and responsiveness. When creating lists, consider using <ul> or <ol> with <li> elements instead of wrapping each item in <div> and <p> tags. You can still customize the bullets using the ::marker pseudo-element. Also, since each card functions as standalone content, using an <article> tag instead of <div> would be more semantically appropriate. Lastly, the current layout does not adapt well when the screen is scaled, so I recommend reviewing responsive design principles to improve adaptability.

    Marked as helpful
  • Abimbola•200
    @Abimzz
    Posted about 2 months ago

    First of all, congratulations on completing the project—it looks great!

    I did notice a few minor issues that could be improved:

    Desktop

    • The .card element is not centered horizontally.
    • The padding at the bottom of .card is not visually balanced with the rest of the card.

    Between 1020px and 430px viewport widths

    • The .card does not fully cover the form area.

    Mobile

    • The page becomes scrollable, which may affect user experience.

    General

    • After dismissing the .successCard, the form fields do not reset.
    • Most of the ARIA roles used are either unnecessary or incorrectly applied.
    • The #resetBtn button does not require a type attribute.

    Suggested Fixes

    Desktop

    • Replace margin-top with margin: 2rem; on .card to properly center it.
    • Adjust padding to ensure visual uniformity at the bottom of .card.

    Between 1020px and 430px

    • Remove fixed height and width properties from .card to allow it to fully cover the form.

    Mobile

    • Remove margin-bottom from .container to prevent unwanted scrolling.
    • For .successCard, set height: 100vh; to fill the viewport height.
    • Replace old padding with 1rem for consistency.
    • Add margin-top: auto; to both .message and #resetBtn to improve layout spacing.

    General

    • In your JavaScript, add emailInput.value = ''; to reset the email field when dismissing .successCard.
    • Remove unnecessary or misused ARIA roles from index.html to improve accessibility.
    • Remove the type="reset" attribute from #resetBtn since it is outside the form and does not require it.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub