Skip to content
Submitted 5 months ago

Newsletter Sign Up With Success Message using plain JavaScript

sass/scss
P
kephalosk•400
@kephalosk
A solution to the Newsletter sign-up form with success message challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

What are you most proud of, and what would you do differently next time?

n/a

What challenges did you encounter, and how did you overcome them?

Outsourcing html code in external files by fetching it via JavaScript.

What specific areas of your project would you like help with?

n/a

Code

Please log in to post a comment

Log in

Community feedback

  • Marcos Travaglini•6,230
    @Blackpachamame

    Greetings! you have done a great job 😎

    📌 Some suggestions

    • Use min-height and max-width, this will help the content stretch or shrink if you need to. Unlike height and width which can cause your content to be cut off on certain screens. For example, use min-height: 100vh instead of height: 100vh
    • Try to avoid using id to style your elements, it is best to do it through classes
    • A good tip for naming CSS classes is to use the BEM methodology.
    • You can apply display: block to the image to remove the white space generated underneath. Although visually in this case it is irrelevant, it helps you better calculate the space with other elements
    • You can add margin: 0 to your *, this will remove the default margin that comes on some HTML elements
    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord