Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 7 months ago

Newsletter Signup Form

accessibility, pure-css
Mayen•440
@Mayen007
A solution to the Newsletter sign-up form with success message challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

What I’m most proud of:

I’m most proud of the overall user experience I was able to create. The form’s responsive design works seamlessly across both desktop and mobile views, and the client-side email validation ensures users get immediate feedback. The success message modal adds a nice touch, making the form feel interactive and polished. It was a rewarding challenge to ensure everything worked together smoothly, especially the transition from error to success states.

What I would do differently next time:

Next time, I’d focus more on improving the accessibility features, such as adding ARIA labels and ensuring the form is fully navigable with a keyboard. I would also like to explore more advanced form validation techniques, perhaps using a library to handle edge cases more efficiently. Finally, I would consider using a JavaScript framework like React for better code organization and scalability in larger projects.

What specific areas of your project would you like help with?

I’d like help with optimizing the performance of the form, particularly with regard to the JavaScript. While the form is functional, I’m sure there are more efficient ways to handle the event listeners and validation logic. I’d also appreciate feedback on improving the accessibility features, such as ensuring the modal and form are fully accessible for users with disabilities. Additionally, I’m interested in best practices for structuring the CSS to ensure scalability and maintainability as the project grows. Any tips or advice on improving these areas would be greatly appreciated!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Nikolay Toshev•310
    @gilotin
    Posted 7 months ago
    • First and most important , don't pollute your code with comments, they are making the code unreadable and can distract you from the code. The code must be self-explanatory. Why I need explanation for .hidden ?
    • About css operations in your script. You can achieve the same effect without messing with the css directly in the script, just create the desired style in a class and apply it when needed with classList.add/remove, it will be cleaner.

    /Edit: I just checked./

    Overall after cleaning the comments , your code isn't that bad. You can move some logic in separate functions and make it more clear and readable.

    Overall, good work.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub