Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Newsletter Signup Form built with BEM, SASS/SCSS, JavaScript and Vite.

#accessibility#bem#vite#sass/scss
Johnnyā€¢ 470

@johnnysedh3lllo

Desktop design screenshot for the Newsletter sign-up form with success message coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


I sorta burnt-out on this project , but i'm glad i was able to finish it, thank God.

Please have a look at my Mark-up, if i made proper Semantic decisions, and Naming decisions in regards to BEM.

What do you think i could've done better? Would really appreciate your feedback.

Community feedback

Alok Sumanā€¢ 2,380

@Alokray007

Posted

Hello there šŸ‘‹

Good job on completing the challenge !

Your project looks really good!

I have a suggestion about your code that might interest you.

There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.

šŸ“Œ Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

I hope this suggestion is useful for future projects.

Other than that, great job!

Happy coding.

1

Johnnyā€¢ 470

@johnnysedh3lllo

Posted

Thank for the feedback @Alokray007.

In regards to the Chrome Extension "Perfect Pixel" that's actually what i used to work on this project but maybe i need to get better at using it.

I appreciate the comment you made on Semantics. Please what tag would you suggest i use in that use case instead of a div or span?

0
Alok Sumanā€¢ 2,380

@Alokray007

Posted

@johnnysedh3lllo You can use Semantic HTML elements like main, section, article etc.

1
Johnnyā€¢ 470

@johnnysedh3lllo

Posted

thanks for the feedback @Alokray007, i appreciate.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord