Skip to content
Submitted 10 months ago

Newsletter Signup Page built with JavaScript

Todd Moussallem•110
@rtoddm
A solution to the Newsletter sign-up form with success message challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

What are you most proud of, and what would you do differently next time?

I am most proud of my use of JavaScript form validation in this project. I had to review several things and learn even more.

What challenges did you encounter, and how did you overcome them?

The challenge that I encountered was learning and applying JS form validation. I consulted several online resources especially MDN Docs.

What specific areas of your project would you like help with?

Three Quick Areas:

  1. Is there a better way to use "rem" in my CSS (best practices) that I failed to implement?
  2. Does my JS form validation adhere to "best practices" or have I implemented that functionality in an eccentric or "hacky" fashion?
Code

Please log in to post a comment

Log in

Community feedback

  • Geo A•230
    @Geo-Bold

    Hi Todd,

    Congratulations for completing this challenge!

    To answer your first question, you should keep in mind that a "rem" is simply a root defined "em" unit and will not change unless the root font size is changed. Think of them as substituting any fixed unit of measurement inside a variable; their values only change if you redefine the root font size. Your use of "rem" is fine, but you should be aware that you can use pixels for precision, "em" units for component-based scaling, percentages for responsive layouts, and the "vw/vh" for viewport based design.

    As for your second question, your use of the defualt browser form validation is sufficient for this project. That being said, it is only a basic level of validation and cannot be relied on to validate all possible valid email formats according to the full specification of email addresses. For example, the following email addresses are considered valid:

    • user+tag@example.com
    • abcde+@c.
    • ------@c.

    For more comprehensive client side authentication it may be useful to look at regex expressions, althought this is just a mere bandaid compared to proper server side authentication with email verification.

    Well done and I hope this helps!

    Geo

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord