Submitted over 1 year ago

Newsletter signup using HTML, CSS and JS

@a-v-o

A solution to the Newsletter sign-up form with success message challenge

Solution retrospective

Do you prefer using regex or functions to validate strings? Is flexbox or grid layout better? Is animation important to you?

Code

Please log in to post a comment

Community feedback

Bryan Li•3,530
@Zy8712
Posted over 1 year ago
Your solution looks pretty good. The main things I'd say you'd need to add is:
- cursor: pointer when the mouse is hovering over the submit button
- you should add a <main> tag around your content, this is for accessbility purposes
- using position absolute to center the box is one way of centering it, another I suggest you to do is using flex box by setting the parent of your container (which in this case is body) to:
```
body{
   width: 100vw;
   height: 100vh;
   display: flex;
   flex-direction: column;
   justify-content: center;
   align-items: center;
}
```
Hope you find my feedback useful 👍
Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord