Newsletter sing up message using CSS, HTLM and JS

Community feedback

• Account deletedPosted over 1 year ago

  I guess you can argue a lot about this. Depending on the complexity of what you are trying to do one could be better than the other. Generally for simple things like email or username validation regex is fine. For more complex calculations personally I would recommend against complex regex because they are not very easy to read + complex to understand therefore very error prone and not easy to fix.

  About the submit button, it's interesting that you choose to do it this way. Most people will try to do some trick like hide the previous card and show a new one with toggling attributes from js. Or doing string interpolation to create the html and then injecting the html into the page.

  The only problem in what you did is that you don't have access to the email from the user input. Probably in reality if you rendered this page in the server you would easily have access to it but in this case you can do probably some hack and either pass it from the url or use a global variable or something like this. And that means that you have to write some js in the success page.

  Edit: Actually string interpolation and then replace the html is probably the most preferred way of doing it in this case. There is no reason for the success card to be a separate page logically speaking. A separate page is making sense if the page itself would make sense to be all alone which in this case it wouldn't. And also you can have access to the email very easy.

  00