Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 2 months ago

newsletter

Olasubomi123•250
@Olasubomi123
A solution to the Newsletter sign-up form with success message challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Gregor de Cillia•190
    @GregorDeCillia
    Posted about 2 months ago

    Hey!

    Looking through your site, I found an unmatched } in styles.css#L78 which seems to break a major part of your layout. The lines before (L64-77) are indented which makes me think they are supposed to go into a different media query?

    The error handling looks good and is even augmented by the bootstrap messages, which is great. Here are some suggestions

    • The email input would look better with more padding and a less subtle styling of the error state
    • Triggering a full reload of the page when the "dismiss message" button is clicked isn't necessary and in bigger projects, you would most likely keep the user on the same page.
    • There are some instances where your user-supplied error messages are not executed because the error handling get shortcut by bootstrap. I'm not sure if that's what you want. The reason this is happening is that the form never gets a submit event if the html/botstrap-side input checks fail. You could listen for a click directly on the button if yo want your validation to be run.
    • The custom images for the <li> bullets seem a bit too close to the text. You could try disabling the bullets an use ::before and ::after instead.
    li {
      position: relative;
    }
    
    li::before {
      content: url('./assets/images/icon-list.svg');
      position: absolute;
      left: -1.5rem;
    }
    

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub