newsletter

Please log in to post a comment
Log in with GitHubCommunity feedback
- @GregorDeCillia
Hey!
Looking through your site, I found an unmatched
}
instyles.css#L78
which seems to break a major part of your layout. The lines before (L64-77) are indented which makes me think they are supposed to go into a different media query?The error handling looks good and is even augmented by the bootstrap messages, which is great. Here are some suggestions
- The email input would look better with more padding and a less subtle styling of the error state
- Triggering a full reload of the page when the "dismiss message" button is clicked isn't necessary and in bigger projects, you would most likely keep the user on the same page.
- There are some instances where your user-supplied error messages are not executed because the error handling get shortcut by bootstrap. I'm not sure if that's what you want. The reason this is happening is that the form never gets a submit event if the html/botstrap-side input checks fail. You could listen for a click directly on the button if yo want your validation to be run.
- The custom images for the
<li>
bullets seem a bit too close to the text. You could try disabling the bullets an use::before
and::after
instead.
li { position: relative; } li::before { content: url('./assets/images/icon-list.svg'); position: absolute; left: -1.5rem; }
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord