newsletter-sign-up
Solution retrospective
None
What challenges did you encounter, and how did you overcome them?None
What specific areas of your project would you like help with?None
Please log in to post a comment
Log in with GitHubCommunity feedback
- @alvarozama
Looks mostly good. Error and active states work properly, so well done on that. Only things I can point out are some details related to design:
1 ) On desktop, the padding of the main's elements is a little off. 2) On mobile, the photo has som padding while in the example design it takes up the entire width of the container. 3) The space between elements on mobile is a little off from the example. 4 ) The success state shows as an element that superimposes on the rest of the page. While I personally think it looks good and clean, the example deign shows as if it was a separate page taking up the entire viewport and hiding the initital main with the form.
Nitpicky observations, I know. It's nothing that big and it could all be corrected easily, but part of the challenge is to make your solution look as close to the design, so it's not entirely unimportant. Other than that, it's a 10/10 from me.
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord