@0xabdulkhalid
Posted
Hello there π. Congratulations on successfully completing the challenge! π
- I have a suggestion regarding your code that I believe will be of great interest to you.
IMPROVING HOVER STATE πͺ:
- I just want to share a small suggestion about the current hover state. I think the borders for the
:before
is not set so during the hover it looks box in shape. We need to add smooth rounded corners for that.
- You have added
border-radius: 7px
forimg
, Instead of adding for that you can add it forimage-link
anchor tag. It's the parent of both things so we could easily add borders and prevent children overflow usingoverflow: hidden
.
- Here's the example:
.nft-card .image-link {
overflow: hidden;
border-radius: 7px;
}
- Now remove this rule,
.nft-card .image-link .image {
border-radius: 7px;
}
- The change we done will help us to achieve nice rounded corners which is evenly distributed for both
img
and:before
for getting the perfect result!
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful
@maiarasteffen
Posted
@0xabdulkhalid Thank you very much for the tip, I will be using it in my next codings!