Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

NFT Card Comp using HTML5 + CSS3

Nour Al-Osman•60
@nalosman
A solution to the NFT preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Got everything except for doing a colour overlay on hover; Any feedback is welcome 👋

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • Vanza Setia•27,715
    @vanzasetia
    Posted over 3 years ago

    Hi, Nalosman! 👋

    Congratulations on completing this challenge! 🎉

    About the image overlay, here are some guidelines:

    • First, wrap the image with an interactive element, in this case, it could be a link that is going to navigate the user to the new page to preview the image.
    • Second, use pseudo-element to create the overlay.
    • Lastly, use background properties to display the eye and the background color.

    You could see my solution as your reference.

    It looks like you want to have a visually hidden h1 which means that it's is visible by assistive technology but hidden for visually. Setting it as display: none; is going to make the h1 hidden for both assistive technology and visually. I would recommend searching the sr-only styling.

    Some feedback:

    • Accessibility
      • All the page content should live inside landmark elements (header, main, and footer). By using them correctly, users of assistive technology navigate the website easily. In this case, wrap all of it with main tag,except the attribution. The attribution should be lived inside the footer.
    <body>
      <main>
        page content goes here...
      </main>
      <footer class="attribution">
          attribution links goes here...
      </footer>
    </body>
    
    • Alternative text for images should not contain any words that related to image (e.g. picture, photo, logo, icon, graphic, avatar, etc). It's already an image element so the screen reader will pronounce it as an image.
    • Use the creator's name as the alternative text for the avatar.
    • Use interactive elements (a) for any elements that have :hover or :active states.
    • Create a custom :focus-visible styling to any interactive elements (button, links, input, textarea). This will make the users can navigate this website using keyboard (by using Tab key) easily.
    • The footer element should be the attribution (outside the main landmark). So, swap the footer in the card element with a div instead.
    • Use CSS border property to create the line. hr element has a role as a separator. In this case, the content below the line should not be separated.
    • Changing the html or root font size can cause huge accessibility implications for those of the users with different font size or zoom requirements. Read what an accessibility expert (Grace Snow) has said about it.
    • Styling
      • To make the card perfectly in the middle of the page, you can make the body element as a flexbox container. By doing that, you can remove the margin from the .card-container.
    /**
     * 1. Make the card vertically center and
     *    allow the body element to grow if needed
     */
    body {
      display: flex;
      align-items: center;
      justify-content: center;
      min-height: 100vh; /* 1 */
    }
    
    • I would recommend using em unit for border-radius on the .card-container to prevent unexpected behavior. Percentage unit is a relative unit and in this case, it is relative or depends on what?

    That's it! Hope you find this useful! 😁

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub