NFT card component

Community feedback

• 

  

  Grace•32,130

  @grace-snow

  Posted over 3 years ago

  Before anything else, check those report errors and fix the html being output in this project. To be honest, the html structure is quite poor at the moment, lacking semantics and foundational things I’d expect to see in a react project. For example

  • text never in divs or spans alone, should be using meaningful elements
  • anything that indicates interactivity like a hover effect always needs an interactive element. Those interactive elements then always need a clear focus-visible style
  • landmark elements are important, even on a tiny project like this, to give structure
  • knowing when and how to write alt text on images and when and how images should be hidden/ignored by bots and assistive tech is important

  These are all really easy things to fix so no need to be disheartened or anything. Just make sure you don’t jump ahead until those foundations are nailed every single time.

  10

  Marked as helpful