Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

NFT Card Component Solution Using Flexbox

Anosha Ahmed•9,300
@anoshaahmed
A solution to the NFT preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I would appreciate opinions on the organization of the HTML and CSS code. Also, if there is a more efficient way to do something than what I chose to do.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Noemi Gali•280
    @NomiDomi
    Posted over 3 years ago

    Hey @anoshaahmed,

    Great job on your first design!

    I checked your other solution too and I saw that you improved tremendously from one design to another so really good job on that!

    I would encourage you to use not just colors in your :root selector but also font size, font family, font weights etc. The idea of having CSS custom properties or variables is to keep everything in one place for cleaner code and easy changes. This might not make so much sense as of now on such small projects, but when you work in big projects this is a must.

    I would also encourage you to take a step away from using pixels for margins, font sizes etc. Pixels don't allow for smooth responsiveness and will lock stuff in place.

    Here are some great tutorials on the different types of units:

    • Are you using the right CSS units?
    • CSS em and rem explained

    FYI I took inspiration from your design for the image overlay so good job on that!

    Hope this helps! Great start and just keep on coding! :)

    Marked as helpful
  • Account deletedPosted over 3 years ago

    Acho que o html poderia ficar melhor, mas resultado esta ótimo, fiz o meu com preguiça.

    Marked as helpful
  • Anton Sukhadolets•330
    @SuhodolecA
    Posted over 3 years ago

    Nice work!

  • Brandon•60
    @walker861
    Posted over 3 years ago

    Thanks for participating Anosha! I am new on my coding journey so I'm only able to speak from my extremely limited experience. Once I had a majority of my solution coded, I found yours on the slack channel. As a newbie, I felt I understood your code fairly easily.

    It helped me figure out how to do the hover states. I have been using The Odin Project but have not been exposed to use of the hover property. So that was extremely helpful. Thanks for posting! Happy coding!

  • roastgrammer•60
    @roastgrammer
    Posted over 3 years ago

    I think this is very nice for your first project and you did it well ! be happy:)

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub