@NomiDomi
Posted
Hey @anoshaahmed,
Great job on your first design!
I checked your other solution too and I saw that you improved tremendously from one design to another so really good job on that!
I would encourage you to use not just colors in your :root selector but also font size, font family, font weights etc. The idea of having CSS custom properties or variables is to keep everything in one place for cleaner code and easy changes. This might not make so much sense as of now on such small projects, but when you work in big projects this is a must.
I would also encourage you to take a step away from using pixels for margins, font sizes etc. Pixels don't allow for smooth responsiveness and will lock stuff in place.
Here are some great tutorials on the different types of units:
FYI I took inspiration from your design for the image overlay so good job on that!
Hope this helps! Great start and just keep on coding! :)
Marked as helpful
@anoshaahmed
Posted
@NomiDomi I appreciate you so much for going over my code and for your helpful feedback!!! I would definitely learn to utilize custom CSS properties, and other forms of units in my future projects. Thank you!