NFT card component usinf HTML and SCSS

Community feedback

• 

  Travolgi 🍕•31,300

  @denielden

  Posted over 3 years ago

  Hi Marvin, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the image
  • You can add the effect :hover creating a div that appears on hover. I used tailwind but you can still see and understand which css properties you can use to do the same. Look here -> my solution
  • use h1 for the title of card instead a simple p
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

  Overall you did well 😁 Hope this help!

  10

  Marked as helpful
• 

  Can•235

  @escarcan

  Posted over 3 years ago

  Hola Marvin, buen trabajo! para solucionar tus 6 errores de accesibilidad recuerda envolver tu codigo HTML en una etiqueta <main>, y ten al menos un <h1> para que no te de errores en el reporte.

  00

  Marked as helpful