Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT card component with HTML & CSS

abizmoβ€’ 750

@abizmo

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Anosha Ahmedβ€’ 9,340

@anoshaahmed

Posted

hey good job on this challenge! your report above shows a few issues though:

  • wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=""; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead. you can read more about landmarks here
  • you should have at least one <h1> in your webpage

here is a list i made of accessibility issues & best practices

hope this helps :))

Marked as helpful

1

abizmoβ€’ 750

@abizmo

Posted

@anoshaahmed Helps a lot! Thanks!

0
Rio Cantreβ€’ 9,710

@RioCantre

Posted

Hello there! Awesome work with this project. Viewing your solution, you did well on the overall design. I think you should considered the following as well...

  • The hover states of the design...
    • in the h3 part into this...
h3:hover {
  color: hsl(178, 100%, 50%);
  cursor: pointer;
}

  • in the footer span into this...
.card__footer span:hover {
  color: hsl(178, 100%, 50%);
  cursor: pointer;
}
  • And add the eye icon with background color for the hover state of the hero image
  • Wrap the .container with specific tag like main and attribution with footer tag for readability
  • Clean the spaces in the code

Once again, Keep up the good work and Cheers!

Marked as helpful

1

abizmoβ€’ 750

@abizmo

Posted

@RioCantre Thank you, i forgot the active design. Just fixed!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord