Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT card preview component HTML CSS

@tovvydumaplin

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


This challenge is great as a beginner. I am open for feedbacks and want to know about the best practices.

Community feedback

Sandro 1,170

@sandro21-glitch

Posted

Hi Tovvy

Here are some suggestions to improve your code:

HTML

Indentation: Use proper indentation to make the code easier to read and maintain.

Alt text: Provide descriptive alt text for images to improve accessibility.

Semantic elements: Use semantic elements where possible, for example <header>, <footer>, and <nav>.

Descriptive class names: Use descriptive class names that accurately reflect the purpose of the elements they style.

CSS

The CSS code looks good, it's well-structured and easy to read. A few suggestions to improve it further:

Use CSS variables to store frequently used values such as color codes, font sizes, etc.

Use CSS grid or flexbox for the layout instead of position absolute, which might make the layout less flexible.

Use shorthand properties, for example, instead of writing margin-bottom: 12px;, you can write margin: 0 0 12px 0;.

Use media queries to make the layout responsive for different screen sizes.

Good Luck

Marked as helpful

0

@tovvydumaplin

Posted

@sandro21-glitch Hi, thank you for the response! Thank you for the detailed explanation, I will take note of this 😃

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord