NFT card using html & css

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

• I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

• This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which causes lacking of landmark for a webpage

• So fix it by replacing the <div class="container"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

• What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

• They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

HEADINGS ⚠️:

• And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

• Every site must want at least one h1 element identifying and describing the main content of the page.

• An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

• So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Hi,

Just a few things that I noticed at a first glance: -you did not apply border-radius to the overlay. Try to apply the same border radius as your image. -try to delay the overlay when hovering. -the difference between the border-radius of the image and the whole component does not seem very aesthetically pleasing. Try to apply the same border-radius and see if you are happy with the results.

Good work anyway