Feedbacks are highly appreciated :)
@L1m1tz
Posted
Hiii, I need improvements on my code so ama learn from yours. In my eyes this is a 10 out of 10 so Well done👏👏👏
Marked as helpful
1
@notabhishekrai
Posted
@L1m1tz Thanks mate. Although I also need to improve a lot :)
0
@denielden
Posted
Hi Notabhishekrai, great work on this challenge! 😉
Here are a few tips for improve your code:
main tag and wrap the card for improve the Accessibilityalt attribute of the imagetransition on the element with hover effectpx use relative units of measurement like rem -> read hereOverall you did well 😁 Hope this help!
Marked as helpful
0
@notabhishekrai
Posted
@denielden thanks mate. Will definately try this.
1
@grace-snow
Posted
Hi
I'm afraid you need to rewrite quite a bit of the html on this...
Anything that has a hover style in the designs means it is interactive. That is a signal to you that you must use an interactive element there (eg a button for actions like toggles or an anchor tag for something that triggers navigation). This is essential.
You are misusing the figure element a lot here too. Figure and figcaption are for encapsulating content that needs a caption. That might be an image, a chart, a blockquote or other content that needs further explanation. It is not meant to be used unless you need that caption. It makes no sense to use figcaption for an icon - the clock and the symbol are decorative, they add no value to the content. So those icons should have empty alt attributes and not be captioned - the text is a simple paragraph tag imo
I hope this helps you
Marked as helpful
1
@notabhishekrai
Posted
@grace-snow thanks alot! I do need alot of improvements in structuring html. I seem to make things work but with wrong approach so this will help me alot. If you could comment on my github code that would really mean the world to me.
0
