Oops! You need to be logged in to do that
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Oops! You need to be logged in to do that
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT card using pure css (sass)

notabhishekraiโ€ข 220

@notabhishekrai

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View Challenge

Design Comparison

SolutionDesign

Report

0

Accessibility Issues

0

HTML Issues

View Report

notabhishekraiโ€™s questions for the community

Feedbacks are highly appreciated :)

Community Feedback

Andrewโ€ข 90

@L1m1tz

Posted

Hiii, I need improvements on my code so ama learn from yours. In my eyes this is a 10 out of 10 so Well done๐Ÿ‘๐Ÿ‘๐Ÿ‘

Marked as helpful

1


notabhishekraiโ€ข 220

@notabhishekrai

Posted

@L1m1tz Thanks mate. Although I also need to improve a lot :)

0

Deniel Denโ€ข 21,560

@denielden

Posted

Hi Notabhishekrai, great work on this challenge! ๐Ÿ˜‰

Here are a few tips for improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the image
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

Overall you did well ๐Ÿ˜ Hope this help!

Marked as helpful

0


notabhishekraiโ€ข 220

@notabhishekrai

Posted

@denielden thanks mate. Will definately try this.

1

Graceโ€ข 21,200

@grace-snow

Posted

Hi

I'm afraid you need to rewrite quite a bit of the html on this...

Anything that has a hover style in the designs means it is interactive. That is a signal to you that you must use an interactive element there (eg a button for actions like toggles or an anchor tag for something that triggers navigation). This is essential.

You are misusing the figure element a lot here too. Figure and figcaption are for encapsulating content that needs a caption. That might be an image, a chart, a blockquote or other content that needs further explanation. It is not meant to be used unless you need that caption. It makes no sense to use figcaption for an icon - the clock and the symbol are decorative, they add no value to the content. So those icons should have empty alt attributes and not be captioned - the text is a simple paragraph tag imo

I hope this helps you

Marked as helpful

1


notabhishekraiโ€ข 220

@notabhishekrai

Posted

@grace-snow thanks alot! I do need alot of improvements in structuring html. I seem to make things work but with wrong approach so this will help me alot. If you could comment on my github code that would really mean the world to me.

0

Please focus on giving high-quality, helpful feedback and answering any questions notabhishekrai might have. Here are some key points to consider:

  • Does the solution include semantic HTML?
  • Is it accessible, and what improvements could be made?
  • Does the layout look good on a range of screen sizes?
  • Is the code well-structured, readable, and reusable?

You can read our community guidelines if you're unsure what to post.

Slack logo

Join our Slack community

Join over 100,000 people taking the challenges, talking about their code, helping each other, and chatting about all things front-end!