NFT card using pure css (sass)

Community feedback

• 

  

  Grace•32,130

  @grace-snow

  Posted about 3 years ago

  Hi

  I'm afraid you need to rewrite quite a bit of the html on this...

  Anything that has a hover style in the designs means it is interactive. That is a signal to you that you must use an interactive element there (eg a button for actions like toggles or an anchor tag for something that triggers navigation). This is essential.

  You are misusing the figure element a lot here too. Figure and figcaption are for encapsulating content that needs a caption. That might be an image, a chart, a blockquote or other content that needs further explanation. It is not meant to be used unless you need that caption. It makes no sense to use figcaption for an icon - the clock and the symbol are decorative, they add no value to the content. So those icons should have empty alt attributes and not be captioned - the text is a simple paragraph tag imo

  I hope this helps you

  11

  Marked as helpful
• 

  Andrew•90

  @L1m1tz

  Posted about 3 years ago

  Hiii, I need improvements on my code so ama learn from yours. In my eyes this is a 10 out of 10 so Well done👏👏👏

  11

  Marked as helpful
• 

  Travolgi 🍕•31,340

  @denielden

  Posted about 3 years ago

  Hi Notabhishekrai, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the image
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

  Overall you did well 😁 Hope this help!

  01

  Marked as helpful