Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT Card - Using SASS, BEM

MohammedC4rβ€’ 10

@MohammedC4r

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Abdulβ€’ 8,560

@Samadeen

Posted

Hey!! Cheers πŸ₯‚ on completing this challenge.. .

Lets firstly work on your accessibility issues.

  • Document should have on main landmark basically means your html should be structured more semantically and the correct format should be your <header>......</header> followed by your <main>......</main> and lastly your <footer>....</footer> hence you should use <main class="card"> instead of <div class="card">.

  • Your footer should be <footer class="attribution"> instead of <div =attribution>

  • Page should contain a level-one heading basically means your html should have a h1 it aid navigation hence <h2 class="card__heading">Equilibrium #3429</h2> should be <h21class="card__heading">Equilibrium #3429</h1> and you should also go down orderly when you are using the headings h1 down to h2 down to h3 and so on.

  • Images must have alternate text - Its hard for screen readers to pick up messages from images without alt text.. Its always advisable to include alt text to aid screen reader

This should fix most of your accessibility issues.

. Regardless you did amazing... hope you find this helpful... Happy coding!!!

Marked as helpful

1

MohammedC4rβ€’ 10

@MohammedC4r

Posted

@Samadeen Thank you firendπŸ₯‚

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord