@visualdenniss
Posted
Hello Tinker :)
Nice job completing the challenge successfully! Suggestions:
- It looks like the span texts are broken into two lines, but in the design they are all in the same line. A quick fix would be using this: white-space: nowrap; for .num-class .eth, .days (i showed this example to make you aware of this property)
but there is even a better way, just use align-items: center;
- .num-class .eth, .days { display: flex; align-items: center; }
Why better than white-space in this case? Cuz if you notice, while it solves line break, the icons seem to be stretched in height a bit, this is because flexbox by default stretches it. align-items: center; not only fixes the line break but also fixes the stretching of the icons.
And no, adding gap: 5px as suggested, won't fix it because that is not the issue.
- Bonus TIP: You can add a transition like transition: all .4s ease; to .equil-img make the overlay appear smoothly.
Hope you find this feedback helpful!
Marked as helpful
@Tiyana19
Posted
@visualdenniss Thank you so much for your suggestion.
just want to ask you if I had used that property white-space
, than what tag I had to use to wrap that icons?
I have updated my solution with align-items: center
.
@visualdenniss
Posted
@Tiyana19 On .num-class .eth, .days
You can play around with the examples here to see what effect it does with which value: https://developer.mozilla.org/en-US/docs/Web/CSS/white-space
Marked as helpful