Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT Component Using HTML and CSS

P
Coty B 405

@cotybro

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Took a break now getting back into things! Open to all feedback and comments!!

Community feedback

Vanza Setia 27,855

@vanzasetia

Posted

Hi, Coty B! Welcome back! 👋

Here are a few suggestions for improvements.

  • Wrap the Equilibrium image with an anchor tag. Any element that has interactivity should be wrapped by an interactive element.
  • Wrap <a href="#" class="component-title">Equilibrium #3429</a> with an <h1>. Each page should have one <h1>.
  • Alternative text for images should not contain any words that are related to "image" (e.g. picture, photo, logo, icon, graphic, avatar, etc). It is already an image element (<img>) so the screen reader will pronounce it as an image.
  • Set box-sizing: border-box on all elements instead of only on the <body> element using universal selector (*).
  • Prefer unitless numbers for line-height values to avoid unexpected results. Learn more — line-height - CSS: Cascading Style Sheets | MDN
  • Never use px unit for font sizes. Use rem or em instead. Relative units such as rem and em can adapt when the users change the browser's font size setting.

I hope this helps. Happy coding! 😄

Marked as helpful

0

P
Coty B 405

@cotybro

Posted

@vanzasetia thank you for all the helpful feedback!

0
Vanza Setia 27,855

@vanzasetia

Posted

@cotybro

You are welcome! 👍

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord