NFT preview card

Community feedback

• 

  Radek•490

  @Radexman

  Posted almost 3 years ago

  Hey, good job on that project! If you don't mind I will provide you some feedback :) .

  A. There is a lot of whitespace in your code which is overall good but if we overdo it may confuse a little bit. Here is some good resource on that:

  https://developer.mozilla.org/en-US/docs/Web/API/Document_Object_Model/Whitespace

  B. I can see that you started with h2 tag, we typically start with h1 and move our way to h6, it is best practice and this tag hierarchy does not confuse screen readers. Another awesome resource:

  https://hammadafzal.com/blog/offpage-seo/h1-h6-headings-and-seo-a-definitive-guide-2022/

  C. I also see you've added classes to some tags like <h2 class ="equilibrium">. There is no need to name this heading just simply use h2 selector in your css. Also it is really good practice to name our classes in semantic way, when we did this project we obviously know to whith part in the DOM "equilibrium" class refers but other devs might not know that from first sight. Try to give short self-explanatory names, I sometimes struggle with naming conventions too :/ .

  Overall amazing job on this one, good luck on next projects and happy coding!

  03

  Marked as helpful