Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT Preview card

Umair 240

@umairanwer

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


My first webdev project, please provide feedback on my code.

Community feedback

P
AK 6,700

@skyv26

Posted

Hi! Umair, Really nice job, I checked you work and design responsiveness and I have noticed few issues.

  1. I saw that your .price-time div container content is not aligned properly. You can also see that your 3 days left text and 0.041ETH text is not aligned properly with respective icon. Just update your CSS code with below:
.time-container {
    display: flex;
    align-items: center;
    gap: 0.25rem;
}

.price-container {
    display: flex;
    align-items: center;
    gap: 0.25rem;
}

by adding above properties in both container you will see some better output.

  1. In mobile response, your card sticked with left edge of the viewport and not aligned properly. and I checked your code and found that you have not added margin: auto; property. So just add this property in your below code
.card-container {
    background-color: hsl(216, 50%, 16%);
    width: 300px;
    border-radius: 10px;
    display: flex;
    flex-direction: column;
    padding: 25px;
    box-shadow: 0px 10px 40px black;
    margin: auto;
}

It will center your card. Below 375px you need to add some margin-top value and then it will be good.

Overall nice job. I hope you understand and my suggestion might be helpful for you.

Best Of Luck

Marked as helpful

1

Umair 240

@umairanwer

Posted

@skyv26 Thank you for your suggestions. I will fix my code accordingly.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord