Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

nft preview card component

IRVINE MESA•1,835
@DrMESAZIM
A solution to the NFT preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


hi guys please requesting for feedback kindly take your time to view my work

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Aneta•180
    @anetaanette
    Posted over 3 years ago

    Hi, good job! A few things you could improve:

    1. the whole card is a bit too big, maybe you could make it smaller to fit the whole card without scrolling.
    2. The "Jules Wyvern" text should change the colour to cyan when hovering too.
    3. The whole "creation of Jules Wyvern" text should be on the side of the avatar, not underneath.
    4. You can change the link to your github or frontend mentor profile in the footer. Overall, good job :) Happy coding! Aneta
    Marked as helpful
  • Web Wizard•5,690
    @rsrclab
    Posted over 3 years ago

    Hi, @DrMESAZIM ~

    Congratulate on your solution to the challenge on FM platform. I have studied your work carefully and learned a lot from it. Especially I like the image overlay effect on your project. Especially I like BEM structuring on your project.

    Here are some of the tips I like to provide.

    • Image overlay border-radius is missing.
    • I suggest you to try transition on hoverable elements like heading and creator name.
    • Please try BEM for naming element classes. It will help you a lot on bigger projects.
    • Alignment and spacings aren't the same with design. As a front-end developer, it's important to meet pixel-perfect requirements.
    • Image tags must have alt attributes as standard.

    https://www.frontendmentor.io/solutions/my-first-solution-on-chanllenge-V-4IzAivH

    Here is my solution to this challenge, and if it can help you even a bit, it would be happy to me.

    Cheers ~

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub