Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT Preview Card Component

Nien 170

@trandainien

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


All comments are welcomeeee (●'◡'●)

Community feedback

David 8,000

@DavidMorgade

Posted

Hello Nien, congrats on finishing the challenge, you are improving a lot since the last challenge I commented you, great job!

There are only a few little changes that I would make:

Change the Equilibrium anchor a tag, to an h1, if you want to keep your a tag, nest the h1 on it, cause your document always need an h1 tag!

Don't use the <picture> tag unless you are gonna render different images with srcset, instead of that you can just nest your img inside the a and the pseudoelements!

Apart from that, nothing more to say, keep it going for harders challenges! hope my feedback helps you in future challenges!

Marked as helpful

1

Nien 170

@trandainien

Posted

@DavidMorgade thank you so much, i will fix it and keep it in mind <3

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord