Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

NFT preview card component

accessibility, bootstrap
Hassan Yahya•250
@hassanyahya400
A solution to the NFT preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


1)how do I make the component fixed and maintain its width for wider screen

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Rio Cantre•9,650
    @RioCantre
    Posted over 3 years ago

    Hello there! Nice work with this one. Viewing at your solution, I would like to recommend the following for you...

    • Remove width: 75%; in the .container to have a fix width.
    • Import the attribution style in the CSS file and remove style tag
    • Wrap the whole content of container with specific tag like main and attribution with `footer tag for readability. For HTML structures, refer it with this one Semantics
    • Include description for the alt in img tags
    • Adjust the opacity of the .img-container:hover .overlay rule set into opacity: 0.8;

    Above all, you did good in implementing the design. Hope this helps and Keep it going!

  • Naveen Gumaste•10,420
    @NaveenGumaste
    Posted over 3 years ago

    Hay ! Hassan Good Job on challenge

    These below mentioned tricks will help you remove any Accessibility Issues

    -> Add Main tag after body <main class="container"></main>

    -> Learn more on accessibility issues

    If this comment helps you then pls mark it as helpful!

    Have a good day and keep coding 👍!

  • vinay kandoi•120
    @vinaximus
    Posted over 3 years ago

    Nice job. Use the max-width property to not go beyond a particular width

  • PhoenixDev22•16,830
    @PhoenixDev22
    Posted over 3 years ago

    Hello @hsn-ng ,

    I have some suggestions regarding your solution:

    HTML

    to tackle the accessibility issues:

    • There should be two landmark components as children of the body element - a main (which will be the NFT card ) and a footer (which will be the attribution).<Footer> should be in the <main >.

    • you can add a <h1> with class="sr-only" (Hidden visually, but present for assistive tech).

    .sr-only {
    	border: 0 !important;
    	clip: rect(1px, 1px, 1px, 1px) !important;
    	-webkit-clip-path: inset(50%) !important;
    		clip-path: inset(50%) !important; 
    	height: 1px !important;
    	margin: -1px !important;
    	overflow: hidden !important;
    	padding: 0 !important;
    	position: absolute !important;
    	width: 1px !important;
    	white-space: nowrap !important;            
    }
    
    
    • Anything with a hover style in a design means it's interactive. you need to add an interactive element around the image and Equilibrium #3429 and Jules Wyvern .

    • It would be better

    
     <h2 class="white-txt hover-text"><a href="#">Equilibrium #3429</a></h2>
     <p class="soft-blue">Creation of <a  class="white-txt hover-text">Jules Wyvern</a></p>
    
    
    • For any decorative images, each img tag should have empty alt="" andaria-hidden="true"attributes to make all web assistive technologies such as screen reader ignore those images in icon-ethereum.svg" , icon-clock.svg" icon-view.svg"

    • the link should be wrapping the original image and either have Sr-only text, an aria-label or alt text that says where that link takes you.

    • The avatar's alt text shouldn't be alt="user" .You can use Jules Wyvern as an alt text.

    • You can read more about alt text

    Hopefully this feedback helps.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub