NFT preview card component

Community feedback

• 

  PhoenixDev22•16,830

  @PhoenixDev22

  Posted almost 3 years ago

  Hi jeevanraj,

  Congratulation on finishing this challenge. Great job on this one! I have few suggestions regarding your solution:

  HTML

  • The most important part in this challenge interactive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) for this imagine what would happen when you click on the image, there are two possible ways:
    1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use <a>.

  For the same reason, you can use <a> to wrap Equilibrium #3429 .

  • The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you.

  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in (icon-view, icon-ethereum, icon-clock ).

  • Profile images like that avatar are valuable content. The alternate text of the avatar’s image should not be empty. You can use the creator's name Jules Wyvern. Read more how to write an alt text

  • look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content

  • If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the <hr>, you can use border-top: to the avatar's part.

  • There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML. The icon view does not really need to be in the HTML. You can use CSS for it.

  Last , there are many unnecessary divs needed to be removed to get clean markup.

  Hopefully this feedback helps.

  01
• 

  abdullahmd2•90

  @abdullahmd2

  Posted almost 3 years ago

  Hey Jeevanraj,

  To change the color of <hr> add the following code in your <hr> tag

  hr {
      background-color: var(--Very-dark-blue-line);
      border: none;
      height: 1px;
  }
  

  You can check this website to know more about styling hr in CSS.

  Also you can add align-items: center; in your body and remove margin-top: 70px; from .logo in your CSS to vertically align the card in center.

  I hope this will help :)

  01
• 

  David•7,960

  @DavidMorgade

  Posted almost 3 years ago

  Hello Jeevanraj congrats on finishing the challenge!

  I will try to answer your questions!

  • To get your hr with the desired color, try using color in your selector instead of background-color, this will get your hr like you want:

    color: var(--Very-dark-blue-line);
  }
  

  • If you want to give a border to an element with CSS you need also to define, the px dimensions of the border and the type of border, for example you could try this on your image: border: 2px solid white;

  • Using your main tag all over your component is totally fine for this challenge, since is the only important part of the page.

  Hope my answers help you, if you have any questions don't hesitate to ask!

  01