@PhoenixDev22
Posted
Hello, I have some suggestions regarding your solution: To tackle the accessibility issues:
- Wrap the body content in
<main>
. a<footer >
for the attribution and it should be out of the<main>
- Page should contain a level-one heading
- you can add a
<h1>
withclass="sr-only"
(Hidden visually, but present for assistive tech).
.sr-only {
border: 0 !important;
clip: rect(1px, 1px, 1px, 1px) !important;
-webkit-clip-path: inset(50%) !important;
clip-path: inset(50%) !important;
height: 1px !important;
margin: -1px !important;
overflow: hidden !important;
padding: 0 !important;
position: absolute !important;
width: 1px !important;
white-space: nowrap !important;
}
-
Anything with a hover style in a design means it's interactive.you need to add an interactive element which is
<a>
around the image andEquilibrium #342
andJules Wyvern
-
For any decorative images, each img tag should have empty
alt=""
andaria-hidden="true"
attributes to make all web assistive technologies such as screen reader ignore those images inalt="clock icon"" , alt="diamond icon"
. -
the eye image doesn't really need to be in the html, you could do it with css. If you want it to stay in html it needs to be aria-hidden or role presentation with empty alt
-
the link should be wrapping the original image and either have
Sr-only
text, anaria-label
oralt
text that says where that link takes you. -
The avatar's alt text shouldn't be only
alt="author picture"
. You can useJules Wyvern
as an alt text. -
Never use
px
for font-size. -
You should use
em
andrem
units .Bothem
andrem
are flexible, Usingpx
won't allow the user to control the font size based on their needs. -
The card has an explicit
width
. Remove thewidth
from the card and change it tomax width: 350px;
instead. That will let it shrink a little when it needs to, It's rarely ever a good practice to set heightsheight: 560px;
on elements . let the content define the height. -
The hover effect on the image is not set properly.
Hopefully this feedback helps.
Marked as helpful
@Infect3d
Posted
@PhoenixDev22 Thank You for Your suggestions. I have learned a lot from You and finally i did make that hover effect working :) Big thanks !