Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT Preview Card Component Challenge

shan1y 190

@shan1y

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I'm learning to code in Canada! Would love to connect with others.

Community feedback

bunee 2,060

@buneeIsSlo

Posted

Hey! @shan1y, Congrats on completing your first challenge. I want to address a few things related to your HTML code.

  • Make sure the webpage has a h1 element as it is important for SEO. Here's an article to learn more about it.

  • Your HTML code can be made much more semantic by using landmarks rather than divs. Replace <div class="container"><div> with <main class="container"><main> and <div class="attribution"><div> with <footer class="attribution"><footer>.

These fixes should remove the accessibility issues on your webpage, Hope this helps :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord