@pikapikamart
Posted
Hey, great work on this one. Layout in general looks great and for mobile state, right now it is fixed to having a 350px so phones with lower width than that will get their content being hidden by screen.
Some suggestion on the site would be:
- Avoid using
height: 100vh
on a large container like themain
as this makes the element's height capped based on the viewport/screen's height. Instead usemin-height: 100vh
so that the element will expand if it needs to. figure
on this one isn't necessary unless you use the image's name as thefigcaption
, if not, just usingimg
is enough.- Also, since the image's name is already present, use it as the image's
alt
. - Since you are making the image interactive on this one with the
:hover
state, you must have an interactive element along with theimg
so that user can focus on it. For this one, if I were to do this, I would use something like:
div.image__container
> button
> img alt
Since hovering on the image creates the overlay where user can like preview the image I supposed? I would create a sr-only
span inside the button
having like preview equilibrium image
text so that user will know what the button
is for. I would place the :hover
state on the .image__container
and do something like:
.image__container:hover > button::after {
show-overlay;
}
- You can use
img
tag on the eth icon since it is being described. - Since the person's name is already present, why not use it as the
img
alt
attribute:> - Lastly, checking at the layout since it is fixed to 350px, there is a
min-width
on the.main
as well, have a check on that one.
Aside from those, great job again on this one.