Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 2 years ago

NFT preview card component css.

Igmacoi•120
@Igmacoi
A solution to the NFT preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


The hover for the image was difficult for me but I managed to complete it and as for the responsive I did not find what the expected result was, so I decided to leave it as it is and the size that I selected for the desktop is quite good and comfortable for phones. Other than that, I liked this challenge

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Zsolt Varjú•490
    @zsoltvarju
    Posted about 2 years ago

    Hello Igmacoi!

    I really like your solution, especially the part where you added the hover effect on the image. I love it!

    I would like to give you some suggestions:

    • You could set your body's height to min-height: 100vh instead of height: 100vh. This way, if the container needs to be bigger, it can. I know that it may not be relevant in this project, but I read somewhere that we should avoid using fixed heights whenever we can because of responsiveness. So, I think it is good to practice.

    • As I mentioned, I really like your approach to the hover effect. However, if you have the time, you should look into the ::before and ::after pseudo-classes, which are a great way to achieve the same effect without adding extra HTML to your index page.

    • In the beginning, you started to add comments in the root section. I think it would be more consistent if you added comments to the whole CSS. It does not need to be very detailed, just mention which part of the design starts where. This makes it a lot easier to read for others and for you too if you plan to revisit the project later. Anyway, keep in mind that these are just suggestions, and your project is great just the way it is.

    Keep up the good work and happy coding! :)

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub