@SuhodolecA
Posted
Hey! Great job! But I think you can do better! I noticed there are empty alt attributes in your html code. It might be better to fill it in. I also recommend you to add transition property in order to add smoothness for interactive elements. And last, сhange fixed width and height of your card, it must be responsive.
Marked as helpful
@vonaser
Posted
Hey! Thanks for the feedback. I added aria-hidden attribute to the images, so I didn't find it necessary to fill alt attributes. If it's needed, I'll fix it. Lastly, I've used rem unit for width and height. I thought that it is useful for responsiveness. What can I use instead of that?
@SuhodolecA
Posted
@vonaser You can try to use max-width instead of width. Don't set the height at all, let content control that, or if you want to set height then use 'vh' units. Well done that you use rem is a good practice and give you flexibility. It's only my opinion. You can do whatever you want. Thanks and good luck!
Marked as helpful
