@VCarames
Posted
Hey @rain-riot, some suggestions to improve you code:
- You didn't apply the hover effect to the NFT image. Heres a link on how to do it:
https://www.w3schools.com/howto/howto_css_image_overlay.asp
-
The NFT Alt Tag description needs to be improved upon. You want to describe what the image is; they need to be readable. Assume youβre describing the image/icon to someone.
-
The Icons serve no other purpose than to be decorative; They add no value. There Alt Tag should left blank and have an aria-hidden=βtrueβ to hides it from assistive technology.
-
You want to wrap your "NFT image", "Equilibrium #3429" and "Jules Wyvern" in anchor tags <a>. This is because they are meant to be links that lead the user to another part of a site.
-
The Attribution needs to be wrapped in a Footer Element.; It's the end of you content.
-
Your CSS Reset is extremely bare. You want to add more to it.
Here are few CSS Resets that you can look at and use to create your own CSS Reset or just copy and paste one that already prebuilt.
https://www.joshwcomeau.com/css/custom-css-reset/
https://meyerweb.com/eric/tools/css/reset/
http://html5doctor.com/html-5-reset-stylesheet/
Happy Coding!
Marked as helpful
@rain-riot
Posted
@vcarames Thankyou for the feedback! i'll do it, thankssss