Vanza Setia• 27,835
@vanzasetia
Posted
Hi, Vitor! 👋
A couple of suggestions:
- Fix invalid HTML:
<h1>must not be a child element of<a>. You can use Caninclude to check whether an element can be inside another element. - No external links: You do not need to have
target="_blank"to every link. Only use it if the users will lose something if the links do not open in a new tab. For example, the links that are required to open when the users fill in a form. - No extra element: You do need a
<div>for the NFT card. You can use the<main>element instead. It is possible by making the<body>element as the flex container of the card instead of using the<main>element. - Do not use pixel unit for font sizes: Use
remoreminstead ofpxfor font sizes. Never usepxunit. Relative units such asremandemcan adapt when the users change the browser's font size setting. Learn more — Why you should never use px to set font-size in CSS and Why font-size must NEVER be in pixels - Unitless
line-height: Always use unitless numbers forline-heightvalues to avoid unexpected results. Learn more — line-height - CSS: Cascading Style Sheets | MDN
I hope my suggestions help you. Have fun coding! 😄
Marked as helpful
1
