Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 3 years ago

NFT preview card component

Robin•150
@Mountainbeach
A solution to the NFT preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I tried making this as similar to the design images as I could, it's obviously not perfect as I didn't have the precise measurements.

Now I feel like the way I "solved" it might be sort of messy. I would greatly appreciate it if you could let me know if you find any ways to clean it up, or ways things could or should have been done better.

ps. This has a horrible mix of using px and rem which is probably bad practice.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • PhoenixDev22•16,830
    @PhoenixDev22
    Posted about 3 years ago

    Hello Robin,

    Congratulation on completing this challenge. I have some suggestions regarding your solution:

    HTML

    • Page should contain a level-one heading. In this challenge , as it’s not a whole page, you can have<h1>visually hidden with sr-only class and use <h2> for Equilibrium #3429. Or you can use <h1> for the Equilibrium #3429

    • The link wrapping the equilibrium image(image-equilibrium ) should either have Sr-only text, an aria-label or alt text that says where that link takes you.

    • For any decorative images, each img tag should have empty alt=""` and add aria-hidden="true"`` attributes to make all web assistive technologies such as screen reader ignore those images in( icon-view, icon-ethereum, icon-clock ).

    • Theicon-viewimage doesn’t really need to be in the html, you can use CSS for this as there is no need for another clutter in the HTML.

    • look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content

    • For the inner part of the card (the icons and the following text )you can use unordered list<ul>. In each <li> should be <img> and ``<p>`that way you can align them centrally (then you don’t need any position relative ) .

    • The avatar's alt should not be empty. You can use the creator's name Jules Wyvern. Read more how to write an alt text

    • To use more semantic tags , you may use <figure> and <figcaption> for the avatar's part.

    CSS:

    • Add min-height: 100vh to the body that let the body grows taller if the content outgrows the visible page instead.

    • It will be very good usage of rem and em on the elements that are crucial like font-size, padding, and margin.

    Aside these, Great work! Hopefully this feedback helps.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub