NFT preview card component

Solution retrospective
I accept recommendations on my solution
Please log in to post a comment
Log in with GitHubCommunity feedback
- @vanzasetia
Hello there, Arturo! 👋
I have some recommendations for the solution.
- It's important to use semantic HTML instead of
div
andspan
elements only. Right now, search engine bots and screen readers would not be able to understand the page content because everything looks the same as far as the meaning.div
andspan
have no meaning for them. - There's an active states on some elements. So, I recommend trying to create the active states styling after you refactor the HTML markup.
- I would highly recommend not specifying the
height
of the container. If you have to, I recommend usingmin-height
instead. - Set a
max-width
instead ofwidth
on the card element. This way, it allows the card to shrink if needed and prevent the card from becoming too large on wide screen.
I hope this feedback is useful! 😁
Marked as helpful - It's important to use semantic HTML instead of
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord