NFT preview card component

Solution retrospective
Hi everyone,
In the beginning, I used only CSS positioning, and it made progress on the project cumbersome. Then with help of CSS flex box, it got easier.
Feedback on code review most welcome!
Please log in to post a comment
Log in with GitHubCommunity feedback
- @MikeBish13
Great job on this project!
One small point: you've used a
<p>
tag to create your image overlay, which is bad practice when we talk about semantic HTML and how browsers, search engines, screen readers, etc interpret your page. A<div>
would probably be better suited here.Better still, you could maybe use a pseudo element to create the image overlay which could also hold the image in the
content
property - that way you don't need to use 2 elements and have 2 hover selectors.Give it a try! Best of luck!
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord