NFT preview card component using Flexbox - SECOND ATTEMPT

Community feedback

• 

  Douo•940

  @Douoo

  Posted almost 3 years ago

  Congrats on finishing the project Mario, a couple of things I suggest you do are:

  1. Use div instead of section for the card. Its always better to use div to contain or group your components. I see that you used <section> to wrap-up your card content which is not recommended. Use section when you want a generic standalone section of a document, which doesn't have a more specific semantic element to represent it. you can find more info about the use of <section> here

  Recommended version would look something like this

  <div class="card">
   <img class="card-img"...>
    <div class="card -content">
     ...
   </div>
  </div
  

  2. Its always best practice to give a descriptive alternate text for your html img elements as its the fallback when the image doesn't render properly
  3. Instead of using <span> for the profile name, I suggest you use <a> tag as its a link. That's it from me! Aside from these issues, I saw that the hover state on the profile name are not active. You've done good visually but you could do much much better to improve your code. Keep up the good work 👍

  03

  Marked as helpful