NFT preview card component using html & css

Solution retrospective
Feedback on this will be great and any feedback on how i can improve this solution will really be helpful. any feedback is appreciated thank you all guys
Please log in to post a comment
Log in with GitHubCommunity feedback
- @Ayon95
Hi, good job completing this challenge. You can make some improvements to your HTML markup and CSS:
HTML
- Try to use semantic HTML elements whenever you can.
- Use the <main> element for the main content of the page.
- An <article> element is appropriate for a piece of content that makes sense on its own, for example, a card like this.
- You can use an <ul> and <li> elements for the card stats section (0.041 ETH, 3 days left).
- A <footer> element is a good choice for the author information section; it'll be like the footer of the article.
- The attribution section should go inside a <footer> element; this will be the footer of the entire page
CSS
- Instead of px, use responsive units like rem and em. These units make it easier to implement responsive web design and they are good for accessibility as well.
- It's good to use CSS variables (custom properties) for values that you use in multiple places in your stylesheet. This will make your CSS code easier to maintain.
Some resources
Hope this helps and good luck on your coding journey :)
Marked as helpful - @NaveenGumaste
Hay ! kasemkl Good Job on challenge
These below mentioned tricks will help you remove any Accessibility Issues
-> Add Main tag after body
<main class="container"></main>
-> Learn more on accessibility issues
If this comment helps you then pls mark it as helpful!
Have a good day and keep coding 👍!
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord