Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT preview card component using scss, grid, and flexbox

#sass/scss

@Ago-oyu

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@rostyslav-nazarenko

Posted

Hi! Great code!

Just a few things to point out

  • picture element can only contain one img element and as many as you need source elements. Change it to general div
  • change color text in the footer and change div to footer
  • using Scss nesting creates problems with specificity
    body main .preview-card .nft__info .flexbox-item .nft__time-left p {}
    
    .nft__time-left p {}
    
    Both selectors target the same element but the first one is more specific which in the big project might create a problem. As I could guess it is your first time using SCSS or is it? Some solutions to this can be leaving body and main selectors alone and then renaming .preview-card to .nft so you can target elements by specifying the next part with & Something like that
    .nft {
      background-color: white;
    
      &__image {}
    
      &__info {}
    }
    
    In the end, you will have just simple class selectors .nft, nft__image, and nft__info

I'm still learn SCSS but I hope my feedback is helpful

Have a excellent day!

1

@Ago-oyu

Posted

@rostyslav-nazarenko thanks for your feedback

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord