NFT preview card component using Tailwind CSS

Community feedback

• 

  P

  Robert McGovern•1,075

  @tarasis

  Posted over 2 years ago

  Oh fudge, my comment failed, apologies this will be more terse. Congrats on finishing the challenge, it looks good. I don't see the problem with the preview image.

  I can't really comment on the CSS/Tailwind, I haven't used it and don't like how cluttered it makes the HTML look. I find it hard to grok.

  First I know these are just challenges, but get into the habit of providing useful alt text. Don't leave it as simply alt="" as you have here.

  Where you can use semantic html rather than divs. For instance the first div has a role of main, in which case, why not use the main tag?

  If an icon isn't important for screenreaders and such then add aria-hidden=true to them. Consider aria-label to provide more info that a sighted person might not need. For instance have an label that said "The price of the NTF image is 0.041 ethereum"

  Best wishes for your next challenge.

  00

  Marked as helpful
• Account deletedPosted over 2 years ago

  Hey @lucaspausin, some suggestions to improve you code:

  • Stay away from using libraries until you fully grasp the fundamentals. This is the purpose of this challenges.

  • Your card is broken. The NFT image is taking up the entire card. I do not use Tailwinds so I can not provide assistance on how to fix it.

  Happy Coding! 👻🎃

  01