Submitted over 2 years ago

NFT preview card component with flex and sass

#sass/scss

Joaquin Trivel• 240

@jtrivel

Preview site View code

This is a solution for...

NFT preview card component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Community feedback

Anton Sukhadolets• 330

@SuhodolecA

Posted over 2 years ago

Hi! Looks great! Really good work! But one little clarification from my side. I think the interactive elements need to be links(<a></a> tags). It means when you click for the headline or main image or creator name you should move to the article, creator profile, etc.

Good luck!

Marked as helpful

Joaquin Trivel• 240

@jtrivel

Posted over 2 years ago

@SuhodolecA thank you for your review, you are totally correct somehow I missed that about the elements needed to be links. will fix it asap. thanks again.

AK• 6,700

@skyv26

Posted over 2 years ago

To solve accessibility issues:

wrap everything in your body in <main> OR give role="" to the direct children of your <body> ... Click here to read more here
Use only one <h1> in your whole one page code.
Don't let alt attribute empty, always add some meaning text in it, so that user able to understand.

<img src="src/images/image-equilibrium.jpg" class="card__img">

Instead do this

<img src="src/images/image-equilibrium.jpg" class="card__img" alt="NFT equillibrium main image">

Good Luck ;)

Marked as helpful

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord