NFT Preview Card Component with Flexbox

Community feedback

• 

  PhoenixDev22•16,830

  @PhoenixDev22

  Posted over 2 years ago

  Hi Maximiliano Torres,

  Congratulation on finishing another frontend mentor challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:

  HTML

  • The most important part in this challenge interactive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) for this imagine what would happen when you click on the image, there are two possible ways:

  1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>.

  2:If clicking the image would navigate the user to another page to see the NFT, here you can use <a>.

  • The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you.

  You should have used <a> to wrap Equilibrium #3429 and Jules Wyvern too.

  • Remember the alternate text should not be hyphenated, it should be human readable.

  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in icon-view, icon-clock, icon-ethereum.

  • Profile images like that avatar are valuable content. The alternate text should not be empty.You can use the creator's name Jules Wyvern. Read more how to write an alt text .

  • The icon view does not really need to be in the HTML. You can use CSS for it.

  • Never use <div> and <span>alone to wrap a meaningful content. Just keep in mind that you should usually use semantic HTML in place of the div tag unless none of them (the semantic tags) really match the content to group together. By adding semantic tags to your document, you provide additional information about the document, which aids in communication. So for middle part of the card class="card-data", you can use an unordered list <ul>, in each <li> there should be <img> and <p>.

  • If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the <div class="card-line"></div>, you can use border-top: to the avatar's part.

  • Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank” attribute, you can expose your site to performance and security issues.

  • line-height: 25px;Use a unitless line-height value to Avoid unexpected results. You can read more in mdn

  • Consider using rem for font size. Absolute units don’t scale for example 15px will always be 15px on the same device. Using pixels is a particularly bad practice for font sizing because it can create some accessibility problems for users with vision impairments.

  Overall great job on this one. Hopefully this feedback helps.

  00

  Marked as helpful