NFT Preview Card

Solution retrospective
maybe you have some remarks about code in this solution? would appreciate for all comments :)
Please log in to post a comment
Log in with GitHubCommunity feedback
- @Hassiai
Replace <h2> with <h1> to fix the accessibility issue.
There is no need to give the body a min-height value.
To center .card on the page using grid, add min-height:100vh to the body.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful - @Mr-jaw
Hi there! 👋
some accessibility issues can be fixed
-
replace
<div class="attribution">
with thefooter
tag (i.e <footer class="attribution"> ... </footer>) -
In the
<div class="flex-group"> ... </div>
rather than using<p>
tag use either<em>
or<strong>
tag to improve accessibility. since <p> is used for paragraphs mostly and not for short text.
I hope this was useful 😊
KEEP GOING! 💪
Marked as helpful -
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord