Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

NFT Preview Card | Flexbox

shuberber•230
@sheronimo
A solution to the NFT preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hi everyone! Any feedback is appreciated, please let me know there's anything I overlooked.

I also have a question about my overlay:

The height of my hover overlay is longer than the NFT image. In dev tools, I determined it to be 5px longer. I assumed this might be because there's no fixed height specified on the containing div, but I'm not sure what's causing it to be longer. Please give me some advice on if there's a way to ensure that they're the exact same size.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Luka•820
    @LukaKobaidze
    Posted over 3 years ago

    Hello!

    To remove extra space to the container, you can add display: block to the image with the class of nft-img

    If you want to know why this happens and why we add display: block to the image, check out this

    Marked as helpful
  • PhoenixDev22•16,830
    @PhoenixDev22
    Posted over 3 years ago

    Hello @sheronimo ,

    I have some suggestions regarding your solution:

    • for the image hover, first it should be wrapped in an anchor tag as already stated. You can add either aria label or Sr onlytext oralt`` text on the image that says where the link goes.

    • The eye image doesn't really need to be in the html, you could do it with css.

    • You can use an unordered list <ul> to wrap class="nft-info"and in each list item would be <img> and <p>.

    • No need for the <hr class="divider" />, you can use border-top: ; to the class="nft-author" . Also , to use more semantic tags , you can use <figure > and <figcaption> for class="nft-author"`.

    Hopefully this feedback helps.

    Marked as helpful
  • Naveen Gumaste•10,420
    @NaveenGumaste
    Posted over 3 years ago

    Hay ! shuberber Good Job on challenge

    These below mentioned tricks will help you remove any Accessibility Issues

    -> Always use the "alt attribute" and just leave it empty bt.. always add it with img tag.

    -> Learn more on accessibility issues

    Keep up the good work!

    Marked as helpful
  • Travolgi 🍕•31,300
    @denielden
    Posted over 3 years ago

    Hi Shuberber, great work !

    Add aspect-ratio: 1; for exact same size to the .overlay class

    And don't forget img element need alt attribute, it's very important

    Hope this help ;)

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub