Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

NFT Preview Card - HTML/CSS/

Dizzy_Sloth•50
@TotallySly
A solution to the NFT preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I really struggled in producing the Overlay. I had to look at a lot of different solutions in order to figure out how this worked. After completion, I am now wondering if the hover elements should have been placed within Anchor tags.....

I need to improve my knowledge of accessibility and aria-labels. Position: Relative and Absolute.

I have not used it on a responsive challenge yet, but I am wondering if using 'Max-Width' helps responsiveness? To my ignorant self, it feels like that should limit the amount of Media Queries. But I know nothing.

Thank you

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • notabhishekrai•180
    @notabhishekrai
    Posted over 3 years ago

    Great Job! But you should wrap all the code inside a <main> </main> (replacing div class = "container" with main class="container" should do) and use atleast 1 H1 tag. These two should solve your accessibility issues.

    for the hover effect, you can just use position relative to the parent and position absolute to child with top and left 0.

    max-width does help in responsive design. If you use max-width of 200px for an image, it will resize when you decrease the screen size but it wont resize(stays the same) when you increase the screen size (to whatever size). Unlike the normal width property.

    Marked as helpful
  • Shashree Samuel•8,860
    @shashreesamuel
    Posted over 3 years ago

    Good job completing this challenge.

    Keep up the good work

    Your solution looks great however I think that the user avatar does not need a border around it

    In terms of your accessibility issues simply wrap all your content between main tags

    I hope this helps

    Cheers Happy coding 👍

    Marked as helpful
  • Dizzy_Sloth•50
    @TotallySly
    Posted over 3 years ago

    Thank you for the feedback, both of you. I keep forgetting about semantic HTML.... that is a massive error on my part. Something I need to change.

    And I am glad my thinking was correct behind the max-width property! I look forward to taking it onto the next challenge

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub