Fraser Watt• 1,790
@fraserwat
Posted
This is looking great - I love the hover animation!!
Couple of things I'd change:
- If you have a
min-height: 100vh(100% screen height) on the <body>, then you can usemargin: autoon the.containerto push your attribution element down to the bottom of the screen instead of being squashed up by your NFT card. You'll probably want to use a bit of padding-bottom on attribution to stop it being right at the bottom. - Think about what semantic HTML elements you can use to structure the page better. E.g.
.attributionas a <footer>. - Change
widthtomax-widthand then use padding to fill out the gap between the edge of the component and the image. Especially when you've got lots of components on the screen, you don't want to be too explicit with widths and heights to make your page more responsive.
Looks fantastic though, keep it up!
Fraser
Marked as helpful
1
