Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 3 years ago

NFT Preview Card using BEM and Flexbox

bem
Jason Greenwald•200
@jaycgreenwald
A solution to the NFT preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Update ** Corrected missing alt tag and background color **

I would love some feedback on my first BEM implementation. Did I follow the naming conventions correctly? What can I do better next time?

I'm curious if there was a more simple way to implement the section I named "card__status". I wrapped the left and right part in separate divs then used Flexbox to space the divs across the section.

Regarding the alt attribute for the images, I left them empty since the images were decorative. Please let me know if this is the right approach or not.

Any accessibility issues I missed and any other feedback on how to improve is much appreciated!

Thank you.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Shashree Samuel•8,860
    @shashreesamuel
    Posted about 3 years ago

    Hey good job completing this challenge

    Keep up the good work

    Your solution looks great however I think that the background color of the body element is supposed to match the color specified in the style-guide.md file.

    In terms of your accessibility issue simply specify a description of your image for your alt attribute.

    I hope this helps Cheers

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub